Enforce DOM integrity, move 3rd party scripts to cdn.jottocraft.com, remove more dead code

Change-Id: I60aedea97116b50e0b1b7cfe3071d9eb3ea80499
Reviewed-on: https://src.jottocraft.com/c/dtps/+/138
Reviewed-by: spike <[email protected]>
diff --git a/scripts/assignments.js b/scripts/assignments.js
index e4169cd..1aa7498 100644
--- a/scripts/assignments.js
+++ b/scripts/assignments.js
@@ -38,7 +38,7 @@
 

             <!-- Assignment title and points -->

             <h4>

-                <span>${assignment.title}</span>

+                <span>${DOMPurify.sanitize(assignment.title)}</span>

 

                 <!-- Points display -->

                 ${scoreHTML ? `<div class="points">${scoreHTML}</div>` : ``}

@@ -50,8 +50,8 @@
                     ${assignment.error ? `<div style="color: #f2392c;" class="infoChip weighted"><i class="fluid-icon">error</i> Error</div>` : ""}

                     ${assignment.dueAt ? `<div ${highlightUnusualDate ? `style="font-weight: bold;color: var(--themeText);background-color: var(--theme);padding: 0px 8px;border-radius: 10px;"` : ""} class="infoChip"><i style="margin-top: -2px;" class="fluid-icon">alarm</i> Due ` + dtps.formatDate(assignment.dueAt) + `</div>` : ""}

                     ${assignment.outcomes ? `<div class="infoChip weighted"><i class="fluid-icon">adjust</i>` + assignment.outcomes.length + `</div>` : ""}

-                    ${assignment.category ? `<div class="infoChip weighted"><i class="fluid-icon">category</i> ` + assignment.category + `</div>` : ""}

-                    ${childDisplay ? `<div class="infoChip weighted"><i class="fluid-icon">person</i> ` + childDisplay + `</div>` : ""}

+                    ${assignment.category ? `<div class="infoChip weighted"><i class="fluid-icon">category</i> ` + DOMPurify.sanitize(assignment.category) + `</div>` : ""}

+                    ${childDisplay ? `<div class="infoChip weighted"><i class="fluid-icon">person</i> ` + DOMPurify.sanitize(childDisplay) + `</div>` : ""}

                 </div>

 

                 <!-- Status icons -->

@@ -83,7 +83,7 @@
             <div class="assignmentGrade">

                 <div class="grade">${Number(assignment.grade.toFixed(2))}</div>

                 <div class="value">/${Number(assignment.value.toFixed(2))}</div>

-                ${assignment.letter ? `<div class="letter">${assignment.letter.replace("incomplete", `<i class="fluid-icon">cancel</i>`).replace("complete", `<i class="fluid-icon">done</i>`)}</div>` : ""}

+                ${assignment.letter ? `<div class="letter">${DOMPurify.sanitize(assignment.letter).replace("incomplete", `<i class="fluid-icon">cancel</i>`).replace("complete", `<i class="fluid-icon">done</i>`)}</div>` : ""}

                 <div class="percentage">${Math.round((assignment.grade / assignment.value) * 100)}%</div>

             </div>

         `;

@@ -353,8 +353,8 @@
         if (update.type == "announcement") {

             updatesHTML += /*html*/`

                 <div onclick="$(this).toggleClass('open');" style="cursor: pointer; padding: 20px; --classColor: ${dtps.classes[update.class].color};" class="announcement card">

-                    <div class="className">${update.title}</div>

-                    ${update.body}

+                    <div class="className">${DOMPurify.sanitize(update.title)}</div>

+                    ${dtps.sanitizeContent(update.body)}

                 </div>

             `;

         } else if (update.type == "assignment") {

@@ -362,13 +362,13 @@
             updatesHTML += /*html*/`

                 <div onclick="dtps.assignment('${update.id}', ${update.class})" style="--classColor: ${dtps.classes[update.class].color};" class="card recentGrade">

                     <h5>

-                        <span>${update.title}</span>

+                        <span>${DOMPurify.sanitize(update.title)}</span>

 

                         <!-- Points display -->

                         ${scoreHTML ? `<div class="points">${scoreHTML}</div>` : ``}

                     </h5>

 

-                    <p>${dtps.user.parent ? "Graded for " + dtps.user.children.find(c => c.id == dtps.classes[update.class].userID).name : "Graded"} at ${dtps.formatDate(update.gradedAt)}</p>

+                    <p>${dtps.user.parent ? "Graded for " + DOMPurify.sanitize(dtps.user.children.find(c => c.id == dtps.classes[update.class].userID).name) : "Graded"} at ${dtps.formatDate(update.gradedAt)}</p>

                 </div>

             `;

         }

@@ -436,7 +436,7 @@
                             <div class='fc-event-title-container'>

                                 <div class='fc-event-title fc-sticky'>

                                     ${missing ? `<i title="Assignment is missing" class="fluid-icon statusIcon">remove_circle_outline</i>` : ``}

-                                    <span style="vertical-align: middle;">${info.event.title}</span>

+                                    <span style="vertical-align: middle;">${DOMPurify.sanitize(info.event.title)}</span>

                                 </div>

                             </div>

                         </div>

@@ -620,9 +620,9 @@
         var computedBackgroundColor = getComputedStyle($(".card.details")[0]).getPropertyValue("--cards");

         var computedTextColor = getComputedStyle($(".card.details")[0]).getPropertyValue("--text");

 

-        var body = assignment.body;

+        var body = dtps.sanitizeContent(assignment.body);

         if ($("body").hasClass("dark")) {

-            body = dtps.brightenTextForDarkMode(assignment.body, computedBackgroundColor);

+            body = dtps.brightenTextForDarkMode(body, computedBackgroundColor);

         }

 

         //Generate a blob with the assignment body and get its data URL

@@ -632,7 +632,7 @@
                     <style>body {background-color: ${computedBackgroundColor}; color: ${computedTextColor};}</style>

                     ${body}

                 `], { type: 'text/html' });

-        assignmentBodyHTML = `<iframe id="assignmentIframe" onload="dtps.iframeLoad('assignmentIframe')" style="margin: 10px 0px; width: 100%; border: none; outline: none;" src="${window.URL.createObjectURL(blob)}" />`;

+        assignmentBodyHTML = `<iframe id="assignmentIframe" onload="dtps.iframeLoad('assignmentIframe')" style="margin: 10px 0px; width: 100%; border: none; outline: none;" src="${window.URL.createObjectURL(blob)}"></iframe>`;

 

     }

 

@@ -642,10 +642,10 @@
         var assignmentRubricHTML = assignment.rubric.map(function (rubricItem) {

             return /*html*/`

                     <div class="dtpsAssignmentRubricItem">

-                        <h5>${rubricItem.title}</h5>

+                        <h5>${DOMPurify.sanitize(rubricItem.title)}</h5>

                         <div class="score">

-                            <p style="color: ${(!generic && rubricItem.color) ? rubricItem.color : "var(--secText)"};" class="scoreName">

-                                ${generic ? "" : (rubricItem.score !== undefined ? rubricItem.scoreName || "" : "Not assessed")}

+                            <p style="color: var(--secText);" class="scoreName">

+                                ${generic ? "" : (rubricItem.score !== undefined ? DOMPurify.sanitize(rubricItem.scoreName || "") : "Not assessed")}

 

                                 <div class="points">

                                     <p class="earned">${generic || (rubricItem.score == undefined) ? "" : rubricItem.score}</p>

@@ -665,11 +665,11 @@
             return /*html*/`

                     <div class="dtpsSubmissionComment">

                         ${feedback.author ? /*html*/`

-                            <img src="${feedback.author.photoURL}" />

-                            <h5>${feedback.author.name}</h5>

+                            <img src="${dtps.escapeAttr(feedback.author.photoURL)}" />

+                            <h5>${DOMPurify.sanitize(feedback.author.name)}</h5>

                         ` : ``}

 

-                        <p>${feedback.comment}</p>

+                        <p>${DOMPurify.sanitize(feedback.comment)}</p>

                     </div>

                 `

         }).join("");

@@ -682,7 +682,7 @@
     $(".card.details").html(/*html*/`

             <i onclick="fluid.cards.close('.card.details'); $('.card.details').html('');" class="fluid-icon close">close</i>

 

-            <h4 style="font-weight: bold;">${assignment.title}</h4>

+            <h4 style="font-weight: bold;">${DOMPurify.sanitize(assignment.title)}</h4>

 

             <div>

                 ${assignment.dueAt ? `<div class="assignmentChip"><i class="fluid-icon">alarm</i><span>Due ${dtps.formatDate(assignment.dueAt)}</span></div>` : ""}

@@ -690,7 +690,7 @@
                 ${assignment.missing && !generic ? `<div  title="Assignment is missing" class="assignmentChip" style="color: #c44848"><i class="fluid-icon">remove_circle_outline</i></div>` : ""}

                 ${assignment.late && !generic ? `<div title="Assignment is late" class="assignmentChip" style="color: #c44848"><i class="fluid-icon">assignment_late</i></div>` : ""}

                 ${assignment.locked && !generic ? `<div title="Assignment submissions are locked" class="assignmentChip" style="color: var(--secText, gray);"><i class="fluid-icon">lock_outline</i></div>` : ""}

-                ${(dtps.user.parent && !generic) ? `<div class="assignmentChip"><i class="fluid-icon">person</i><span>${dtps.user.children.find(c => c.id == dtps.classes[assignment.class].userID).name}</span></div>` : ""}

+                ${(dtps.user.parent && !generic) ? `<div class="assignmentChip"><i class="fluid-icon">person</i><span>${DOMPurify.sanitize(dtps.user.children.find(c => c.id == dtps.classes[assignment.class].userID).name)}</span></div>` : ""}

                 ${generic ? "" : scoreHTML}

             </div>

 

@@ -701,7 +701,7 @@
                           <h5><i class="fluid-icon">error</i> Assignment Error</h5> 

                         </div> 

 

-                        <p>${assignment.error}</p> 

+                        <p>${DOMPurify.sanitize(assignment.error)}</p> 

                     </div>

                 </div>

             ` : ``}

@@ -717,15 +717,15 @@
                 ${assignment.dueAt ? `<p style="color: var(--secText); margin: 5px 0px;"><i style="vertical-align: middle;" class="fluid-icon">alarm</i> Due: ${dtps.formatDate(assignment.dueAt)}</p>` : ""}

                 ${assignment.value ? `<p style="color: var(--secText); margin: 5px 0px;"><i style="vertical-align: middle;" class="fluid-icon">bar_chart</i> Point value: ${assignment.value}</p>` : ""}

                 ${(assignment.grade || (assignment.grade == 0)) && !generic ? `<p style="color: var(--secText); margin: 5px 0px;"><i style="vertical-align: middle;" class="fluid-icon">assessment</i> Points earned: ${assignment.grade}</p>` : ""}

-                ${assignment.letter && !generic ? `<p style="color: var(--secText); margin: 5px 0px;"><i style="vertical-align: middle;" class="fluid-icon">font_download</i> Letter grade: ${assignment.letter}</p>` : ""}

-                ${assignment.category ? `<p style="color: var(--secText); margin: 5px 0px;"><i style="vertical-align: middle;" class="fluid-icon">category</i> Category: ${assignment.category}</p>` : ""}

-                ${assignment.rubric ? assignment.rubric.map(function (rubricItem) { return `<p style="color: var(--secText); margin: 5px 0px;"><i style="vertical-align: middle;" class="fluid-icon">adjust</i> ${rubricItem.title}</p>`; }).join("") : ""}

-                <p style="color: var(--secText); margin: 5px 0px;"><i style="vertical-align: middle;" class="fluid-icon">class</i> Class: ${dtps.classes[assignment.class].subject}</p>

+                ${assignment.letter && !generic ? `<p style="color: var(--secText); margin: 5px 0px;"><i style="vertical-align: middle;" class="fluid-icon">font_download</i> Letter grade: ${DOMPurify.sanitize(assignment.letter)}</p>` : ""}

+                ${assignment.category ? `<p style="color: var(--secText); margin: 5px 0px;"><i style="vertical-align: middle;" class="fluid-icon">category</i> Category: ${DOMPurify.sanitize(assignment.category)}</p>` : ""}

+                ${assignment.rubric ? assignment.rubric.map(function (rubricItem) { return `<p style="color: var(--secText); margin: 5px 0px;"><i style="vertical-align: middle;" class="fluid-icon">adjust</i> ${DOMPurify.sanitize(rubricItem.title)}</p>`; }).join("") : ""}

+                <p style="color: var(--secText); margin: 5px 0px;"><i style="vertical-align: middle;" class="fluid-icon">class</i> Class: ${DOMPurify.sanitize(dtps.classes[assignment.class].subject)}</p>

                 ${dtps.env == "dev" ? `<p style="color: var(--secText); margin: 5px 0px;"><i style="vertical-align: middle;" class="fluid-icon">code</i> Assignment ID: ${assignment.id}</p>` : ""}

 

                 <br />

                 <div class="row">

-                    ${assignment.url ? `<button class="btn small outline" onclick="window.open('${assignment.url}')"><i class="fluid-icon">open_in_new</i> Open in ${dtpsLMS.shortName || dtpsLMS.name}</button>` : ``}

+                    ${assignment.url ? `<button class="btn small outline" onclick="window.open(${dtps.escapeAttr(JSON.stringify(dtps.safeURL(assignment.url)))})"><i class="fluid-icon">open_in_new</i> Open in ${dtpsLMS.shortName || dtpsLMS.name}</button>` : ``}

                 </div>

             </div>

 

@@ -829,23 +829,23 @@
                 var action = "";

                 if (item.type == "assignment") action = "dtps.assignment('" + item.id + "', " + classNum + ")";

                 if (item.type == "page") {

-                    action = "fluid.screen('pages', '" + classID + "|" + item.id + "|true')";

+                    action = "fluid.screen('pages', " + JSON.stringify(classID + "|" + item.id + "|true") + ")";

                 }

                 if (item.type == "discussion") {

                     action = "fluid.screen('discussions', '" + classID + "|" + item.id + "|true')";

                 }

-                if (item.type == "url") action = "window.open('" + item.url + "')";

+                if (item.type == "url") action = "window.open(" + JSON.stringify(dtps.safeURL(item.url)) + ")";

                 if (item.type == "header") action = "";

-                if (item.type == "embed") action = "dtps.showIFrameCard('" + item.url + "')";

+                if (item.type == "embed") action = "dtps.showIFrameCard(" + JSON.stringify(dtps.safeURL(item.url)) + ")";

 

                 //Get module HTML

                 if (item.type == "header") {

-                    moduleItemHTML += `<h5 style="font-size: 16px;padding: 0px 10px; text-decoration: underline;">${item.title}</h5>`;

+                    moduleItemHTML += `<h5 style="font-size: 16px;padding: 0px 10px; text-decoration: underline;">${DOMPurify.sanitize(item.title)}</h5>`;

                 } else {

                     moduleItemHTML += `

-                        <div class="moduleItem" onclick="${action}" style="margin-left: ${item.indent * 15}px;">

+                        <div class="moduleItem" onclick="${dtps.escapeAttr(action)}" style="margin-left: ${item.indent * 15}px;">

                             <i ${item.completed ? `style="color: #27ba3c"` : ""} class="fluid-icon">${item.completed ? "check" : icon}</i>

-                            ${item.title}

+                            ${DOMPurify.sanitize(item.title)}

                         </div>

                     `;

                 }

@@ -857,7 +857,7 @@
                     <h4>

                         <i onclick="dtps.moduleCollapse(this, '${dtps.classes[classNum].id}', '${module.id}');" 

                             class="fluid-icon collapseIcon">${module.collapsed ? "keyboard_arrow_right" : "keyboard_arrow_down"}</i>

-                        ${module.title}

+                        ${DOMPurify.sanitize(module.title)}

                     </h4>

 

                     <div class="moduleContents" style="padding-top: 10px;">

@@ -1018,10 +1018,10 @@
             assignmentHTML += /*html*/`

                 <div onclick="dtps.assignment('${assignment.id}', ${classNum})" class="gradebookAssignment">

                     <h5>

-                        ${assignment.title}

+                        ${DOMPurify.sanitize(assignment.title)}

 

                         <div class="stats">

-                            ${assignment.letter ? `<div class="gradebookLetter">${assignment.letter}</div>` : ""}

+                            ${assignment.letter ? `<div class="gradebookLetter">${DOMPurify.sanitize(assignment.letter)}</div>` : ""}

                             <div class="gradebookScore">${Math.round(assignment.grade * 100) / 100}</div>

                             <div class="gradebookValue">/${Math.round(assignment.value * 100) / 100}</div>

                             <div class="gradebookPercentage">${Math.round((assignment.grade / assignment.value) * 100)}%</div>

@@ -1047,7 +1047,7 @@
                 Grade Summary

                 <div class="classGradeCircle">

                     ${dtps.classes[classNum].grade ? `<div class="percentage">${dtps.classes[classNum].grade}%</div>` : ``}

-                    ${dtps.classes[classNum].letter ? `<div class="letter">${dtps.classes[classNum].letter}</div>` : ""}

+                    ${dtps.classes[classNum].letter ? `<div class="letter">${DOMPurify.sanitize(dtps.classes[classNum].letter)}</div>` : ""}

                 </div>

             </h3>